fix: fix flakey rust tests #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to fix the following flakey tests: 1. `test_txo_validation` 2. `test_transaction_resending` The fix for 1 was to put in an explicit wait for the validation protocol to complete, on the slower CI system is seems that the validation protocol was slow to update the database state before the main test queried the balance. The fix for 2 is to increase the cool down and resend times to make them more resilient to the slower CI environment. The current times were quite tight which was fine on a local dev machine. This might still prove to be flakey in the future.
delta1
approved these changes
Oct 8, 2021
| .is_err()); | ||
|
|
||
| // Wait for the cooldown to expire but before the resend period has elapsed see if a repeat illicts a reponse. | ||
| runtime.block_on(async { sleep(Duration::from_secs(2)).await }); | ||
| // Wait for the cooldown to expire but before the resend period has elapsed see if a repeat illicts a response. |
There was a problem hiding this comment.
lol
Suggested change
| // Wait for the cooldown to expire but before the resend period has elapsed see if a repeat illicts a response. | |
| // Wait for the cooldown to expire but before the resend period has elapsed see if a repeat elicits a response. |
stringhandler
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the following flakey tests:
test_txo_validationtest_transaction_resendingThe fix for 1 was to put in an explicit wait for the validation protocol to complete, on the slower CI system is seems that the validation protocol was slow to update the database state before the main test queried the balance.
The fix for 2 is to increase the cool down and resend times to make them more resilient to the slower CI environment. The current times were quite tight which was fine on a local dev machine. This might still prove to be flakey in the future.
How Has This Been Tested?
These are fixes to tests