Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix flakey rust tests #3435

Merged
merged 2 commits into from
Oct 8, 2021
Merged

fix: fix flakey rust tests #3435

merged 2 commits into from
Oct 8, 2021

Commits on Oct 8, 2021

  1. fix: fix flakey rust tests 

    This PR aims to fix the following flakey tests:
1. `test_txo_validation`
2. `test_transaction_resending`

The fix for 1 was to put in an explicit wait for the validation protocol to complete, on the slower CI system is seems that the validation protocol was slow to update the database state before the main test queried the balance.

The fix for 2 is to increase the cool down and resend times to make them more resilient to the slower CI environment. The current times were quite tight which was fine on a local dev machine. This might still prove to be flakey in the future.
    @philipr-za
    philipr-za committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    76bd13d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into philip-flakey-tests

    @aviator-app
    aviator-app[bot] committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    b53c0a1 View commit details
    Browse the repository at this point in the history