feat: add asset key manager to collectibles #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta1
commented
Nov 23, 2021
|
|
||
| // update the assets key manager for this wallet | ||
| state | ||
| .set_asset_key_manager(result.cipher_seed.clone(), "assets".into(), index) |
There was a problem hiding this comment.
need to move this magic constant out into an actual const
| results | ||
| .iter() | ||
| .map(|k| KeyIndex { | ||
| id: Uuid::from_slice(&k.id).unwrap(), |
There was a problem hiding this comment.
need to clean up unwraps
stringhandler
approved these changes
Nov 23, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Dec 12, 2021
* development: (77 commits) chore: merge development refactor: split transaction file (tari-project#3653) refactor: change transaction mod name chore: fix imports fmt (tari-project#3650) feat: add 721 template stub (tari-project#3643) feat: add transfer method to tip002 (tari-project#3632) feat: add connect per site into the web extension (tari-project#3626) refactor: fix db structure (tari-project#3616) feat: add asset key manager to collectibles (tari-project#3609) ci: update validator-node CI for faster feedback (tari-project#3606) feat: add state database (tari-project#3591) feat: add wallet stub to collectibles app (tari-project#3589) feat: add onboarding flow for web extension (tari-project#3582) feat: compile key manager to wasm and add javascript interface (tari-project#3565) feat: add storage to validator node (tari-project#3551) fix: wallet was not able to run (tari-project#3561) feat: add react popup with some basic functionality (tari-project#3550) feat: create tari web extension application stub (tari-project#3535) chore: merge dev refactor: move conversion ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a key manager for an "assets" branch to the collectibles app.
Refactors asset registration to accept a provided public key.
Some additional work to be done but wanted to get this in first since there are likely conflicts with #3604