feat: resize base node terminal on startup #3827
Conversation
zhangcheng
force-pushed
the
development
branch
from
d77c442
to
9054c1c
Compare
|
Thank you @zhangcheng ! Will test it when I can |
delta1
changed the title
|
Tested on macos, can confirm it resizes |
@delta1 Do we also want to resize to fit the height of the box? |
I think that would be great @zhangcheng 👍 take a look and if you can include that, if there's issues then this can go in first while you hack on it! |
|
Just need signed commits and can merge it |
Description --- Use [crossterm](https://github.com/crossterm-rs/crossterm) crate to resize cli properly. Motivation and Context --- My very first `good first issue` to work on tari codebase. ;-) How Has This Been Tested? --- Tested on macOS Monterey (12.1). Works for system Terminal app. Doesn't work for iTerm2.
zhangcheng
force-pushed
the
development
branch
from
9054c1c
to
6ca0bef
Compare
I will try to add the height resize tomorrow. |
Description --- To resolve tari-project#1728 better Motivation and Context --- As a follow-up of tari-project#3827. How Has This Been Tested? --- Tested on macOS Monterey (12.1). Works for system Terminal app. Doesn't work for iTerm2.
|
A follow-up PR #3838 , please take a look when you have time. @delta1 , @mikethetike |
* development: (28 commits) fix(wallet): fix aggressive disconnects in wallet connectivity (tari-project#3807) chore: honor decimals in ERC20 (tari-project#3809) chore: add icons to applications (tari-project#3812) fix: daily test (tari-project#3815) ci: improvements to macos pkg (tari-project#3824) ci: cargo test speedups (tari-project#3843) feat: add persistence of transaction cancellation reason to wallet db (tari-project#3842) fix: update RFC links and README (tari-project#3675) (tari-project#3839) chore: change NodeIdentity debug (tari-project#3817) fix(dan): include state_root in node hash (tari-project#3836) feat(cli): resize terminal height (tari-project#3838) feat(validator-node): initial state sync implementation (partial) (tari-project#3826) feat: update console wallet tui (tari-project#3837) feat: resize base node terminal on startup (tari-project#3827) feat(wallet): add grpc method for setting base node (tari-project#3828) chore(deps): bump follow-redirects from 1.14.5 to 1.14.8 in /applications/tari_web_extension_example (tari-project#3832) chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /applications/tari_collectibles/web-app (tari-project#3833) chore(deps): bump follow-redirects from 1.14.5 to 1.14.8 in /applications/tari_web_extension (tari-project#3834) chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /applications/launchpad/gui-vue (tari-project#3831) chore(deps): bump follow-redirects from 1.14.4 to 1.14.8 in /integration_tests (tari-project#3829) ...
feat(cli): resolves (#1728) Command Line Resize.
Description
Use crossterm crate to resize cli properly.
Motivation and Context
My very first
good first issueto work on tari codebase. ;-)How Has This Been Tested?
Tested on macOS Monterey (12.1).
Works for system Terminal app.
Doesn't work for iTerm2.