-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change NodeIdentity debug #3817
Merged
aviator-app
merged 2 commits into
tari-project:development
from
Cifko:nodeidentity-debug
Feb 15, 2022
Merged
chore: change NodeIdentity debug #3817
aviator-app
merged 2 commits into
tari-project:development
from
Cifko:nodeidentity-debug
Feb 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
previously approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sdbondi
reviewed
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one nit
2b580b6
to
8ab67e5
Compare
8ab67e5
to
299a09b
Compare
stringhandler
approved these changes
Feb 15, 2022
sdbondi
approved these changes
Feb 15, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Feb 17, 2022
* development: (28 commits) fix(wallet): fix aggressive disconnects in wallet connectivity (tari-project#3807) chore: honor decimals in ERC20 (tari-project#3809) chore: add icons to applications (tari-project#3812) fix: daily test (tari-project#3815) ci: improvements to macos pkg (tari-project#3824) ci: cargo test speedups (tari-project#3843) feat: add persistence of transaction cancellation reason to wallet db (tari-project#3842) fix: update RFC links and README (tari-project#3675) (tari-project#3839) chore: change NodeIdentity debug (tari-project#3817) fix(dan): include state_root in node hash (tari-project#3836) feat(cli): resize terminal height (tari-project#3838) feat(validator-node): initial state sync implementation (partial) (tari-project#3826) feat: update console wallet tui (tari-project#3837) feat: resize base node terminal on startup (tari-project#3827) feat(wallet): add grpc method for setting base node (tari-project#3828) chore(deps): bump follow-redirects from 1.14.5 to 1.14.8 in /applications/tari_web_extension_example (tari-project#3832) chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /applications/tari_collectibles/web-app (tari-project#3833) chore(deps): bump follow-redirects from 1.14.5 to 1.14.8 in /applications/tari_web_extension (tari-project#3834) chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /applications/launchpad/gui-vue (tari-project#3831) chore(deps): bump follow-redirects from 1.14.4 to 1.14.8 in /integration_tests (tari-project#3829) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove secret_key from debug print for
NodeIdentity
. The display is using the same fields that are used in thefmt::Display
trait