feat: remove spawn blocking calls from wallet db (contacts service) #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed spawn blocking calls for db operations from the wallet in the contacts manager service. (This is another PR in a couple of PRs required to implement this fully throughout the wallet code.) - Reset the wallet's default db connection pool size back to 16 (from 5).
stringhandler
approved these changes
Aug 31, 2022
| @@ -136,7 +136,7 @@ impl Default for WalletConfig { | |||
| base_node_service_config: Default::default(), | |||
| data_dir: PathBuf::from_str("data/wallet").unwrap(), | |||
| db_file: PathBuf::from_str("db/console_wallet.db").unwrap(), | |||
| db_connection_pool_size: 5, // TODO: get actual default | |||
| db_connection_pool_size: 16, // Note: Do not reduce this default number | |||
There was a problem hiding this comment.
this is really high. I was expecting it to be only one or two connections at a time
There was a problem hiding this comment.
From the start we have always tested with 16; this number slipped in somewhere. Effectively it makes read operation asynchronous.
hansieodendaal
deleted the
ho_remove_spawn_bocking_calls_contacts_service
branch
jorgeantonio21
pushed a commit
to jorgeantonio21/tari
that referenced
this pull request
Aug 31, 2022
…ari-project#4575) Description --- - Removed spawn blocking calls for db operations from the wallet in the contacts service. (This is another PR in a couple of PRs required to implement this fully throughout the wallet code.) - Reset the wallet's default db connection pool size back to 16 (from 5). Motivation and Context --- As per tari-project#3982 and tari-project#4555 How Has This Been Tested? --- Unit tests Cucumber tests System-level test
This was referenced Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
As per #3982 and #4555
How Has This Been Tested?
Unit tests
Cucumber tests
System-level test