fix: add burn funds command to console wallet (see issue #4547) #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4547. |
There was a problem hiding this comment.
Looking good, but I believe we need a cucumber test for this:
- Let a miner connected to a wallet mine some blocks (20?)
- Mine some blocks (3?) without a connected wallet to have all funds available
- Verify the miner wallet's available balance (and possibly the balance of the entire UTXO set)
- Create and submit a burn funds transaction to burn (almost) all funds in the wallet
- Mine some blocks (3?) without a connected wallet
- Verify the balance of the entire UTXO set
Comment on lines
624
to
625
| BurnFunds(args) => { | ||
| match burn_tari( |
There was a problem hiding this comment.
I think these two names should match - BurnFunds vs. burn_tari
There was a problem hiding this comment.
Definitely ! Thanks for the suggestions
…21/tari into ja_add_burn_funds_on_wallet
|
Happy to merge, but let's add the cucumber test first |
|
We have cucumber tests for the burns, verify balance etc. Look at: |
This was referenced Sep 14, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Sep 16, 2022
* development: (72 commits) fix: reinsert transactions from failed block (tari-project#4675) fix: stray clippy error (tari-project#4685) fix(wallet): mark mined_height as null when pending outputs are cancelled (tari-project#4686) chore: updated dependancies (tari-project#4684) fix(p2p): remove DETACH flag usage (tari-project#4682) fix(comms): simplify and remove possibility of deadlock from pipelines and substream close (tari-project#4676) feat(ci): add default CI and FFI testing with custom dispatch (tari-project#4672) chore: remove broken test (tari-project#4678) fix: fix potential race condition between add_block and sync (tari-project#4677) fix deadlock (tari-project#4674) fix: add burn funds command to console wallet (see issue tari-project#4547) (tari-project#4655) v0.38.3 fix: fee estimate (tari-project#4656) fix(comms/messaging): fix possible deadlock in outbound pipeline (tari-project#4657) fix: replace Luhn checksum with DammSum (tari-project#4639) fix(core/sync): handle deadline timeouts by changing peer (tari-project#4649) fix(ci): libtor build on Ubuntu (tari-project#4644) chore: fix log (tari-project#4634) v0.38.2 fix(comms/rpc): detect early close in all cases (tari-project#4647) ...
stringhandler
pushed a commit
that referenced
this pull request
Sep 20, 2022
Description --- Refactor previously incorrect cucumber for burn funds via cli test. Motivation and Context --- PR #4655 introduced a specific cucumber for testing burn funds via cli. This test was incorrectly designed. This PR addresses the situation. How Has This Been Tested? --- Cucumber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds command to burn funds on Tari console wallet.
Motivation and Context
Tackle issue #4547.
How Has This Been Tested?
Proper unit tests.