fix: reduce buffer allocation size #4830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjS77
added
P-acks_required
AaronFeickert
changed the title
|
Addressed in PR 4832. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces the size of a buffer allocation when padding messages for encryption.
Closes issue 4829.
Motivation and Context
As noted in issue 4829, the
BytesMutused to hold messages during padding and encryption allocates more space than is needed, possibly due to a mistaken assumption of the behavior ofreserve(...). This PR ensures that the minimum number of extra bytes needed for padding is reserved, avoiding unnecessarily large allocation.How Has This Been Tested?
Existing tests.