fix(dht): fix over allocation for encrypted messages #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
CjS77
added
P-acks_required
sdbondi
force-pushed
the
dht-fix-over-alloc
branch
from
3983a66
to
a554923
Compare
sdbondi
force-pushed
the
dht-fix-over-alloc
branch
from
a554923
to
6299569
Compare
|
LGTM |
CjS77
added
P-merge
CjS77
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resizeto improve 0 padding performanceMotivation and Context
reserveargument is additional bytes not total.Fixes #4829
resize also allows the addition of padding bytes using raw pointer operations which are presumed to be much quicker than using rust iterators.
How Has This Been Tested?
Updated unit test to check for a correct capacity.