Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix custom wallet startup logic for console wallet #5429

Merged
merged 2 commits into from
May 31, 2023
Merged

fix: fix custom wallet startup logic for console wallet #5429

merged 2 commits into from
May 31, 2023

Conversation

hansieodendaal
Copy link
Contributor

Description

Added logic so that the wallet will not ask to connect to a detected base node if a custom base node has already been set in the database.

Motivation and Context

The custom-configured base node was ignored.

How Has This Been Tested?

System-level testing

What process can a PR reviewer use to test or verify this change?

  • Start console wallet without config.wallet.custom_base_node set where a base node is running locally and accept the prompt to connect to the detected base node.
  • With Network tab configure a custom base node that is different to the one that is running locally.
  • Exit.
  • Restart the console walle.
  • Verify that the user is not prompted again to connect to the local base node.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal
Fix custom wallet startup logic
2a8dfd9 
Added a logic so that the wallet will not ask to connect to a detected base node if
a custom base node has already been set in the database.
@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited

Test Results (CI)

1 148 tests  ±0   1 148 ✔️ ±0   10m 4s ⏱️ -2s
     37 suites ±0          0 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit bfdb20d. ± Comparison against base commit 9d0d8b5.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 31, 2023
@github-actions
Copy link

Test Results (Integration tests)

  2 files  +  2  12 suites  +12   26m 14s ⏱️ + 26m 14s
29 tests +29  27 ✔️ +27  0 💤 ±0  2 ❌ +2 
31 runs  +31  29 ✔️ +29  0 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 2a8dfd9. ± Comparison against base commit 9d0d8b5.

SWvheerden
SWvheerden approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 31, 2023
@SWvheerden SWvheerden merged commit 0c1e576 into tari-project:development May 31, 2023
14 checks passed
@hansieodendaal hansieodendaal deleted the ho_fix_custom_db_logic branch June 2, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansieodendaal @SWvheerden @ghpbot-tari-project