Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header sync #5647

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Fixes audit findings of header sync.
Changes Pow comparison to look at less than, rather than less and equal.
Block peer from sending known headers.
Block peer from sending headers out of order.

Motivation and Context

Audit findings TARI-013 and TARI-016

Audit Finding Number

TARI-013 , TARI-016

@SWvheerden SWvheerden added the C-audit_fix fixes bug found in the audit label Aug 17, 2023
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Test Results (CI)

1 196 tests   1 196 ✔️  8m 54s ⏱️
     37 suites         0 💤
       1 files           0

Results for commit 2506991.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 17, 2023
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Test Results (Integration tests)

27 tests   27 ✔️  14m 8s ⏱️
11 suites    0 💤
  2 files      0

Results for commit 2506991.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 1, 2023
@stringhandler stringhandler merged commit 4583eef into tari-project:development Sep 1, 2023
14 checks passed
@SWvheerden SWvheerden deleted the sw_fix_header_sync branch September 12, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-audit_fix fixes bug found in the audit P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants