fix(chatffi): return and read from ptrs #5827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
brianp
force-pushed
the
fix-metadata-reads
branch
from
b481061
to
1618db3
Compare
SWvheerden
approved these changes
Oct 4, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A unit struct was being returned within a c_rep struct. This caused the unit struct to have no body in the header file and caused build errors in ios. This unit struct should have been a pointer with read functions and not returned as a rust unit struct. This PR moves it over to a pointer and corrects it's readers.
Motivation and Context
Don't produce broken builds.
A lot of types around this fix will be removed soon after this is merged but it this corrects a broken build and it would be nicer to work on top of this PR, then ignore it and fix the grand scheme.
How Has This Been Tested?
Built and provided to the mobile team. Confirmed no build errors.
What process can a PR reviewer use to test or verify this change?
Skim the code, but honestly don't look too close it's about to churn.
Breaking Changes