feat: prevent runtime error with compact error input #6096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)1 264 tests 1 264 ✅ 14m 17s ⏱️ Results for commit a47a07b. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 13m 1s ⏱️ For more details on these failures, see this check. Results for commit a47a07b. ♻️ This comment has been updated with latest results. |
Prevented compact error input where a runtime error occurs when commitment cannot be retrieved form a compact input.
hansieodendaal
force-pushed
the
ho_prevent_compact_input_error
branch
from
9339dff
to
bf92088
Compare
SWvheerden
approved these changes
Jan 25, 2024
ghpbot-tari-project
removed
the
P-reviews_required
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 26, 2024
* development: feat: prevent runtime error with compact error input (tari-project#6096) chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091) chore: update monero to latest release (tari-project#6098) chore(deps): bump actions/cache from 3 to 4 (tari-project#6093) chore(fix): ci - move s3 uploads to only on release (tari-project#6094) feat: update codeowners (tari-project#6088) chore: update change log (tari-project#6086) feat: add search kernels method to nodejs client (tari-project#6082)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 26, 2024
* development: (84 commits) chore: merge development to feature-dan2 (tari-project#6100) feat: prevent runtime error with compact error input (tari-project#6096) chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091) chore: update monero to latest release (tari-project#6098) chore(deps): bump actions/cache from 3 to 4 (tari-project#6093) chore(fix): ci - move s3 uploads to only on release (tari-project#6094) feat: update codeowners (tari-project#6088) chore: update change log (tari-project#6086) feat: add search kernels method to nodejs client (tari-project#6082) chore: move domain hash names to separate crate (tari-project#6076) chore: new esme release (tari-project#6084) fix: tms validation correctly updating (tari-project#6079) fix: wallet coinbases not validated correctly (tari-project#6074) chore(fix): ci - ffis android - add protobuf for cross-compile (tari-project#6083) chore(fix): include protobuf during build (tari-project#6077) chore: upgrade tonic and prost (tari-project#6067) feat: add tari address as valid string for discovering a peer (tari-project#6075) docs: update disclosure policy (tari-project#6072) chore(ci): ffi extend to build for none mobile platforms (tari-project#6069) refactor(common): allow custom default configs (tari-project#6068) ...
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 26, 2024
* development: (85 commits) revert: merge development to feature-dan2 (tari-project#6100) (tari-project#6102) chore: merge development to feature-dan2 (tari-project#6100) feat: prevent runtime error with compact error input (tari-project#6096) chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091) chore: update monero to latest release (tari-project#6098) chore(deps): bump actions/cache from 3 to 4 (tari-project#6093) chore(fix): ci - move s3 uploads to only on release (tari-project#6094) feat: update codeowners (tari-project#6088) chore: update change log (tari-project#6086) feat: add search kernels method to nodejs client (tari-project#6082) chore: move domain hash names to separate crate (tari-project#6076) chore: new esme release (tari-project#6084) fix: tms validation correctly updating (tari-project#6079) fix: wallet coinbases not validated correctly (tari-project#6074) chore(fix): ci - ffis android - add protobuf for cross-compile (tari-project#6083) chore(fix): include protobuf during build (tari-project#6077) chore: upgrade tonic and prost (tari-project#6067) feat: add tari address as valid string for discovering a peer (tari-project#6075) docs: update disclosure policy (tari-project#6072) chore(ci): ffi extend to build for none mobile platforms (tari-project#6069) ...
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 26, 2024
* development: (85 commits) revert: merge development to feature-dan2 (tari-project#6100) (tari-project#6102) chore: merge development to feature-dan2 (tari-project#6100) feat: prevent runtime error with compact error input (tari-project#6096) chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091) chore: update monero to latest release (tari-project#6098) chore(deps): bump actions/cache from 3 to 4 (tari-project#6093) chore(fix): ci - move s3 uploads to only on release (tari-project#6094) feat: update codeowners (tari-project#6088) chore: update change log (tari-project#6086) feat: add search kernels method to nodejs client (tari-project#6082) chore: move domain hash names to separate crate (tari-project#6076) chore: new esme release (tari-project#6084) fix: tms validation correctly updating (tari-project#6079) fix: wallet coinbases not validated correctly (tari-project#6074) chore(fix): ci - ffis android - add protobuf for cross-compile (tari-project#6083) chore(fix): include protobuf during build (tari-project#6077) chore: upgrade tonic and prost (tari-project#6067) feat: add tari address as valid string for discovering a peer (tari-project#6075) docs: update disclosure policy (tari-project#6072) chore(ci): ffi extend to build for none mobile platforms (tari-project#6069) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent runtime error when calculating the commitment from a compact input.
Motivation and Context
Under certain conditions, the blockchain db can be in a state where a runtime error can occur where it does not need to.
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Code walk-through
Breaking Changes