Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update codeowners #6088

Merged
merged 1 commit into from
Jan 22, 2024
Merged

feat: update codeowners #6088

merged 1 commit into from
Jan 22, 2024

Conversation

CjS77
Copy link
Collaborator

@CjS77 CjS77 commented Jan 19, 2024

Marks CI/CD files as sensitive and requiring a review by a DevOps team member.

Sensitive consensus needs a lead maintainer review.

other base layer code requires a review by core devs.

** REQUIRES "require reviews by codeowners" setting in branch protection rules **

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jan 19, 2024
Copy link

github-actions bot commented Jan 19, 2024

Test Results (CI)

1 264 tests   1 264 ✅  10m 19s ⏱️
   39 suites      0 💤
    1 files        0 ❌

Results for commit 733b68a.

♻️ This comment has been updated with latest results.

Marks CI/CD files as sensitive and requiring a review by a DevOps team
member.

Sensitive consensus needs a lead maintainer review.

other base layer code requires a review by core devs.

** REQUIRES "require reviews by codeowners" setting in branch protection
rules **
Copy link
Contributor

@leet4tari leet4tari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Jan 19, 2024
Copy link

Test Results (Integration tests)

29 tests   29 ✅  12m 7s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit 733b68a.

@CjS77 CjS77 added the P-merge Process - Queued for merging label Jan 19, 2024
@CjS77
Copy link
Collaborator Author

CjS77 commented Jan 19, 2024

ACK

@ghpbot-tari-project ghpbot-tari-project removed the P-acks_required Process - Requires more ACKs or utACKs label Jan 19, 2024
@SWvheerden
Copy link
Collaborator

ACK

@SWvheerden SWvheerden merged commit 58a131d into development Jan 22, 2024
13 of 14 checks passed
sdbondi added a commit to sdbondi/tari that referenced this pull request Jan 26, 2024
* development:
  feat: prevent runtime error with compact error input (tari-project#6096)
  chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091)
  chore: update monero to latest release (tari-project#6098)
  chore(deps): bump actions/cache from 3 to 4 (tari-project#6093)
  chore(fix): ci - move s3 uploads to only on release (tari-project#6094)
  feat: update codeowners (tari-project#6088)
  chore: update change log (tari-project#6086)
  feat: add search kernels method to nodejs client (tari-project#6082)
sdbondi added a commit to sdbondi/tari that referenced this pull request Jan 26, 2024
* development: (84 commits)
  chore: merge development to feature-dan2 (tari-project#6100)
  feat: prevent runtime error with compact error input (tari-project#6096)
  chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091)
  chore: update monero to latest release (tari-project#6098)
  chore(deps): bump actions/cache from 3 to 4 (tari-project#6093)
  chore(fix): ci - move s3 uploads to only on release (tari-project#6094)
  feat: update codeowners (tari-project#6088)
  chore: update change log (tari-project#6086)
  feat: add search kernels method to nodejs client (tari-project#6082)
  chore: move domain hash names to separate crate (tari-project#6076)
  chore: new esme release (tari-project#6084)
  fix: tms validation correctly updating (tari-project#6079)
  fix: wallet coinbases not validated correctly (tari-project#6074)
  chore(fix): ci - ffis android - add protobuf for cross-compile (tari-project#6083)
  chore(fix): include protobuf during build (tari-project#6077)
  chore: upgrade tonic and prost (tari-project#6067)
  feat: add tari address as valid string for discovering a peer (tari-project#6075)
  docs: update disclosure policy (tari-project#6072)
  chore(ci): ffi extend to build for none mobile platforms (tari-project#6069)
  refactor(common): allow custom default configs (tari-project#6068)
  ...
sdbondi added a commit to sdbondi/tari that referenced this pull request Jan 26, 2024
* development: (85 commits)
  revert: merge development to feature-dan2 (tari-project#6100) (tari-project#6102)
  chore: merge development to feature-dan2 (tari-project#6100)
  feat: prevent runtime error with compact error input (tari-project#6096)
  chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091)
  chore: update monero to latest release (tari-project#6098)
  chore(deps): bump actions/cache from 3 to 4 (tari-project#6093)
  chore(fix): ci - move s3 uploads to only on release (tari-project#6094)
  feat: update codeowners (tari-project#6088)
  chore: update change log (tari-project#6086)
  feat: add search kernels method to nodejs client (tari-project#6082)
  chore: move domain hash names to separate crate (tari-project#6076)
  chore: new esme release (tari-project#6084)
  fix: tms validation correctly updating (tari-project#6079)
  fix: wallet coinbases not validated correctly (tari-project#6074)
  chore(fix): ci - ffis android - add protobuf for cross-compile (tari-project#6083)
  chore(fix): include protobuf during build (tari-project#6077)
  chore: upgrade tonic and prost (tari-project#6067)
  feat: add tari address as valid string for discovering a peer (tari-project#6075)
  docs: update disclosure policy (tari-project#6072)
  chore(ci): ffi extend to build for none mobile platforms (tari-project#6069)
  ...
sdbondi added a commit to sdbondi/tari that referenced this pull request Jan 26, 2024
* development: (85 commits)
  revert: merge development to feature-dan2 (tari-project#6100) (tari-project#6102)
  chore: merge development to feature-dan2 (tari-project#6100)
  feat: prevent runtime error with compact error input (tari-project#6096)
  chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091)
  chore: update monero to latest release (tari-project#6098)
  chore(deps): bump actions/cache from 3 to 4 (tari-project#6093)
  chore(fix): ci - move s3 uploads to only on release (tari-project#6094)
  feat: update codeowners (tari-project#6088)
  chore: update change log (tari-project#6086)
  feat: add search kernels method to nodejs client (tari-project#6082)
  chore: move domain hash names to separate crate (tari-project#6076)
  chore: new esme release (tari-project#6084)
  fix: tms validation correctly updating (tari-project#6079)
  fix: wallet coinbases not validated correctly (tari-project#6074)
  chore(fix): ci - ffis android - add protobuf for cross-compile (tari-project#6083)
  chore(fix): include protobuf during build (tari-project#6077)
  chore: upgrade tonic and prost (tari-project#6067)
  feat: add tari address as valid string for discovering a peer (tari-project#6075)
  docs: update disclosure policy (tari-project#6072)
  chore(ci): ffi extend to build for none mobile platforms (tari-project#6069)
  ...
@CjS77 CjS77 deleted the add-codeowners branch February 21, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-merge Process - Queued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants