fix: wallet validation during reorgs #6173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 117 suites 34m 29s ⏱️ Results for commit da27952. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 20m 51s ⏱️ + 20m 51s For more details on these failures, see this check. Results for commit da27952. ± Comparison against base commit c6f2b8d. |
base_layer/wallet/src/output_manager_service/tasks/txo_validation_task.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wallet validation during reorgs.
Motivation and Context
spent outputs that have been reorged, should not be marked as unspent. They should be marked as unspen_mined_unconfirmed
If they are marked as unspent it means the wallet can immeadatly grab the output and use it in a new transaction. The validation service first needs to find out what the status of that output is, allthou the wallet knows the original block the transaction was mined in was reorged out, it needs to figure out if the transaction is still mined, unmined or mempool.