Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): metadata panic #6247

Merged
merged 7 commits into from
Apr 10, 2024
Merged

fix(chat): metadata panic #6247

merged 7 commits into from
Apr 10, 2024

Commits on Apr 4, 2024

  1. Remove panic and out of bounds error in metadata addition

    @brianp
    brianp committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1b37cbf View commit details
    Browse the repository at this point in the history

  2. Standardize functions returning non signed ints

    @brianp
    brianp committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    06c11e2 View commit details
    Browse the repository at this point in the history

  3. Prevent underflows and panics by removing arithmetic that may try to … 

    …subtract from 0 where 0 may be an unsigned int
    @brianp
    brianp committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a8246a9 View commit details
    Browse the repository at this point in the history

  4. Add new types to MetadataType enum

    @brianp
    brianp committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    621d85f View commit details
    Browse the repository at this point in the history

  5. Return proper error value

    @brianp
    brianp committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    38a2734 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Remove the metadata type enum in favour of allowing the client to def… 

    …ine whatever they want
    @brianp
    brianp committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5e1dc88 View commit details
    Browse the repository at this point in the history

  2. Clippy fixes

    @brianp
    brianp committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    58bb7d8 View commit details
    Browse the repository at this point in the history