Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeError when subscription connection is reset. #50

Closed
jonypawks opened this issue Sep 11, 2019 · 0 comments · Fixed by #51
Closed

RuntimeError when subscription connection is reset. #50

jonypawks opened this issue Sep 11, 2019 · 0 comments · Fixed by #51

Comments

@jonypawks
Copy link

Sometimes when a subscription client has reset their connection, tartiflette-aiohttp will raise a RuntimeError with the message: dictionary changed size during iteration. I've tracked the issue down to the following line:

for operation_id in connection_context.operations:

Changing this to list(connection_context.operations.keys()) fixed the issue for me locally, not sure if that's the preferred approach though. I don't have a simple test case for this but mutating the dictionary while iterating over it is certainly a bug anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant