Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable outline on focusable elements. #35

Closed
NullVoxPopuli opened this issue Mar 15, 2020 · 0 comments · Fixed by #36
Closed

Re-enable outline on focusable elements. #35

NullVoxPopuli opened this issue Mar 15, 2020 · 0 comments · Fixed by #36

Comments

@NullVoxPopuli
Copy link

Not sure why outline was deliberately, removed, hiding the indication of where your keyboard focus is:

https://github.com/tastejs/todomvc-app-css/blob/master/index.css#L37

I've found that in a more accessible TodoMVC implementation, I need to add the following CSS:

/* this block re-adds the outline, to support keyboard navigation / tabbing */
:focus,
.view label:focus,
.todo-list li .toggle:focus + label,
.toggle-all:focus + label {
  /* !important needed, because todomvc styles deliberately disable the outline */
  outline: #d86f95 solid !important;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant