Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check page speed for each new PR #1692

Open
denar90 opened this issue Sep 22, 2016 · 1 comment
Open

Check page speed for each new PR #1692

denar90 opened this issue Sep 22, 2016 · 1 comment
Assignees

Comments

@denar90
Copy link
Contributor

denar90 commented Sep 22, 2016

I propose to run page speed for checking each new PR.
Purpose of running it with localhost, that new PR don't have to be merged to check page speed.
We are currently implementing this approach for marionettejs.com - marionettejs/marionettejs.com#486
The effort of this is insurance that newly PR is not downgrading page speed for site. I wrote small module - https://github.com/denar90/psi-ngrok, which helps run psi locally. Hence either it or some another approach can be used.

@FadySamirSadek
Copy link
Collaborator

@denar90 I like the idea a lot and will work on implementing it, I am also thinking about making a full audit on each PR and give it a lighthouse score so we can understand more how the change made affected the app. Thank you so much for sharing this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants