Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade/Rewrite EmberJS example for Ember Octane #2140

Open
sukima opened this issue Jan 18, 2021 · 5 comments
Open

Upgrade/Rewrite EmberJS example for Ember Octane #2140

sukima opened this issue Jan 18, 2021 · 5 comments

Comments

@sukima
Copy link

sukima commented Jan 18, 2021

EmberJS has introduced a significant change to its paradigm. This latest edition is called Octane and has been in use in the wild for about a year now. The future of EmberJS will be to continue expanding on this newer paradigm.

The TODO app—being a representative of modern EmberJS programming—should reflect this as well. It means upgrading the current example to the latest version of Ember and converting the current code to use Octane patterns.

This issue is a request to update and modernize the current EmberJS example.

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Jan 18, 2021

I have a version of it implemented here: https://github.com/NullVoxPopuli/ember-todomvc-tutorial/tree/master/steps/00-finished-todomvc/todomvc

This is what is featured in the EmberJS MDN tutorial

@NullVoxPopuli
Copy link
Contributor

I also started a PR here: #2103 but either C.I. is broken or a rebase will get it passing again

@sukima
Copy link
Author

sukima commented Jan 18, 2021

I was just going to do it because I thought it was something fun to do on a holiday. But the contributing guides said I had to make an issue first and get permission discuss it first. 🤷

@NullVoxPopuli
Copy link
Contributor

Ah, maybe that's why my PR has no comments. Hmm. Feel free to pick it up if you want. I'll add you to the fork

@NullVoxPopuli
Copy link
Contributor

Gonna do this here #2209 but as Polaris, instead of Octane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants