Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broke example #62

Closed
boushley opened this issue Jan 18, 2012 · 6 comments
Closed

Update broke example #62

boushley opened this issue Jan 18, 2012 · 6 comments
Milestone

Comments

@boushley
Copy link
Contributor

  1. Need to update the html/css/folder structure to match the new template.
  2. Update to the latest version of the libraries.
@boushley
Copy link
Contributor Author

Other deficiencies:

  • Edit icon should be removed.
  • Edit should be performed on double click.
  • Need to add "Mark all complete" checkbox.
  • Footer should be hidden when there are no tasks.
  • How many completed string needs to be added to footer.
  • Clear completed button should have completed count.
  • Need to update delete icon to the standard

@sindresorhus
Copy link
Member

@brokenseal Would you be interested in updating this to our new template?

We have a lot of example apps to update and fix, and the popular ones take priority. Though I would like this to get updated, since I'm a active Django dev, I find Broke interesting. This would also be a good example when we add server-browser communication examples.

@brokenseal
Copy link
Contributor

Hey, I've never seen this issue before, sorry.
I will update my example during the course of this week, thanks for notifyinf me @sindresorhus

By the way, you might be interested in the fact that I'm thinking about giving a lightning talk at eurodjangocon this year about broke.

Cheers!
Davide

@sindresorhus
Copy link
Member

Awesome, thanks! :D

Make sure you follow the template in the template directory, both file/folder structure and HTML/CSS. Some more info.

Let me know if you have any questions or need help getting this done.

@brokenseal
Copy link
Contributor

I'm currently working on it https://github.com/brokenseal/todomvc/commit/501f2f94c49289e4e01e99b975e0af0c527580d5 but please, next time, create an issue on my repository :)

By the way, if you are interested in Broke what it really needs now is a community behind it since I'm the only one working on it and I find less and less time to spend on it (last update is 5 months old).

Cheers,
Davide

@brokenseal
Copy link
Contributor

#113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants