Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of GismoExport #77

Merged
merged 32 commits into from
Dec 16, 2022
Merged

First draft of GismoExport #77

merged 32 commits into from
Dec 16, 2022

Conversation

jzwar
Copy link
Collaborator

@jzwar jzwar commented Dec 10, 2022

Gismo Export with multipatch attachement

Description

New features

  • multipatch class
  • connectivity for embedded systems using uff-like algorithm from bezman
  • Face-Center property for splines
  • gismo export with multipatch systems
  • boundary extraction for splines

WIP part

Some additional features are defined in issue number #81

Showcase

A short / one-liner example to highlight the (new) feature

# Init multipatch with some splines
multipatch = sp.Multipatch(splines=[bez_el0, rbz_el1, bsp_el2, nur_el3])


# Define some functions for boundary identification
def is_boundary(x):
    return x[:, 0] < 0.01

# Add boundary
multipatch.add_boundary_with_function(is_boundary)

# Test Output
sp.io.gismo.export("test2D.xml", multipatch)

All interface connectiities are then available for export and more

Checklists

  • Documentations are up-to-date.
  • Added example(s)
  • Added test(s)

@jzwar jzwar added enhancement New feature or request medium Medium Workload required (~1 day) labels Dec 10, 2022
@jzwar jzwar requested a review from j042 December 10, 2022 18:07
@jzwar jzwar self-assigned this Dec 10, 2022
@j042 j042 mentioned this pull request Dec 13, 2022
cpp/splinepy/py/py_spline.hpp Outdated Show resolved Hide resolved
Copy link
Member

@j042 j042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

cpp/splinepy/py/py_spline.hpp Show resolved Hide resolved
cpp/splinepy/py/py_spline.hpp Outdated Show resolved Hide resolved
cpp/splinepy/py/py_spline.hpp Outdated Show resolved Hide resolved
cpp/splinepy/py/py_spline.hpp Outdated Show resolved Hide resolved
cpp/splinepy/py/py_spline.hpp Outdated Show resolved Hide resolved
splinepy/multipatch.py Outdated Show resolved Hide resolved
splinepy/multipatch.py Outdated Show resolved Hide resolved
splinepy/multipatch.py Show resolved Hide resolved
splinepy/multipatch.py Show resolved Hide resolved
tests/test_gismo.py Outdated Show resolved Hide resolved
@j042
Copy link
Member

j042 commented Dec 15, 2022

whenever you are ready, can remove WIP. Can you write some plans for follow-up multi patch extensions in the PR description above?

@jzwar jzwar changed the title (WIP) First draft of GismoExport First draft of GismoExport Dec 15, 2022
@jzwar jzwar requested a review from j042 December 16, 2022 07:57
Copy link
Member

@j042 j042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you !

@jzwar jzwar merged commit 0a70cb5 into main Dec 16, 2022
@jzwar jzwar deleted the ft-gismo-export branch December 16, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium Medium Workload required (~1 day)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants