Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practices for handling google.protobuf.timestamp? #228

Open
talksik opened this issue Jun 27, 2024 · 2 comments
Open

Best practices for handling google.protobuf.timestamp? #228

talksik opened this issue Jun 27, 2024 · 2 comments

Comments

@talksik
Copy link

talksik commented Jun 27, 2024

What are best ways to deal with this? Perhaps we abstract completely here in twirpscript so that it's out of the way?

I saw this, but wasn't sure if anything progressed here: tatethurston/ProtoScript#43

@tatethurston
Copy link
Owner

tatethurston commented Jun 28, 2024

Hey @talksik, yeah I held off on implementing that functionality to wait to see if there was any interest.

I think I’m still inclined to automatically parse google.protobuf.timestamp into a Date, and then later when Temporal lands, migrate to that.

@talksik
Copy link
Author

talksik commented Jun 29, 2024

@tatethurston Temporal sounds interesting...finally someone trying to solve this problem hollistically :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants