Use fcntl and FD_CLOEXEC if O_CLOEXEC is undefined #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same reported at nghttp2#87 but at src/shrpx_config.cc src/instead of util.cc
|
Thank you for PR! Could you check my comment? |
|
fixed and tested, compiled like a charm |
|
|
||
| // We get race condition if execve is called at the same time. | ||
| if(fd != -1) { | ||
| int make_socket_closeonexec_(fd); |
There was a problem hiding this comment.
This is not correct to me.
I proposed specifically util::make_socket_closeonexec(fd);
|
Merged via 7ea8037 |
acesso
pushed a commit
to acesso/nghttp2
that referenced
this pull request
Mar 2, 2015
declaration of make_socket_closeonexec need the proper scope here, it was there per request at nghttp2#142 , not sure why is was removed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same reported at #87 but at src/shrpx_config.cc src/instead of util.cc