Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Window::set_ignore_cursor_events, closes #184 #421

Merged
merged 4 commits into from
Jun 13, 2022
Merged

feat: Window::set_ignore_cursor_events, closes #184 #421

merged 4 commits into from
Jun 13, 2022

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Co-authored-by: Markus Siglreithmaier m.siglreith@gmail.com
Co-authored-by: z4122 412213484@qq.com
Co-authored-by: Kirill Chibisov contact@kchibisov.com

amrbashir and others added 4 commits June 11, 2022 18:37
@amrbashir @msiglreith
@z4122 @kchibisov
feat: Window::set_ignore_cursor_events, closes #184
d828ce1 
Co-authored-by: Markus Siglreithmaier <m.siglreith@gmail.com>
Co-authored-by: z4122 <412213484@qq.com>
Co-authored-by: Kirill Chibisov <contact@kchibisov.com>
@amrbashir
linux attempt failed
124fdf7
@amrbashir
changefile
1dc13e1
@amrbashir
linux
6c80f51
@amrbashir amrbashir marked this pull request as ready for review June 12, 2022 15:49
@amrbashir amrbashir requested a review from a team June 12, 2022 15:49
@amrbashir amrbashir requested a review from a team as a code owner June 12, 2022 15:49
@amrbashir amrbashir merged commit 4fa8761 into dev Jun 13, 2022
@amrbashir amrbashir deleted the set_ignore_mouse_events branch June 13, 2022 10:26
@github-actions github-actions bot mentioned this pull request Jun 13, 2022
Merged
@TheConfuZzledDude TheConfuZzledDude mentioned this pull request Jul 27, 2022
Closed
@jabza
Copy link

jabza commented Aug 21, 2022

This looks great, any idea how I can call this API? I'm not seeing this function on my Window object

@majorsopa
Copy link

@jabza it appears to be on the Window itself, not the WindowBuilder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amrbashir @jabza @majorsopa @wusyong