Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest.json file is not generated if productName contains spaces #843

Closed
killerDJO opened this issue Jul 1, 2024 · 0 comments · Fixed by #845
Closed

latest.json file is not generated if productName contains spaces #843

killerDJO opened this issue Jul 1, 2024 · 0 comments · Fixed by #845

Comments

@killerDJO
Copy link

Steps to reproduce:

  1. Specify "productName": "With spaces" in tauri.conf.json
  2. Run github action
  3. latest.json is not uploaded, warning is printed into the log: Asset not found for the updater JSON. Skipping upload...

This seems to be a regression in a recent PR #766. In scope of it, a new approach has been introduced to detect zip file based on a signature file name: https://github.com/tauri-apps/tauri-action/pull/766/files#diff-aa2bda70857754a372eebc7152d28dbd36dba171538840d29aa7cbfa024ace09R131
However, when generating a basename normalization is not applied (spaces and other special symbols are not replaced with dots). Bacause of this, asset is not found and warning is printed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant