fix(updater): Use escaped installer path when starting the updater msi (

#8234) * fix(updater): Use escaped installer path when starting the updater msi Continuation of #7956 * fix build
tauri-apps · Nov 15, 2023 · 4b6a602 · 4b6a602
1 parent 92bc7d0
commit 4b6a602
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changes/updater-msi-escaped-path.md b/.changes/updater-msi-escaped-path.md
@@ -0,0 +1,5 @@
+---
+'tauri': 'patch:bug'
+---
+
+Escape path of the updater msi to avoid crashing on installers with spaces.
diff --git a/core/tauri/src/updater/core.rs b/core/tauri/src/updater/core.rs
@@ -844,7 +844,7 @@ fn copy_files_and_run<R: Read + Seek>(
           "-ArgumentList",
         ])
         .arg("/i,")
-        .arg(msi_path_arg)
+        .arg(&msi_path_arg)
         .arg(format!(", {}, /promptrestart;", msiexec_args.join(", ")))
         .arg("Start-Process")
         .arg(current_exe_arg)
@@ -858,7 +858,7 @@ fn copy_files_and_run<R: Read + Seek>(
         );
         let _ = Command::new(msiexec_path)
           .arg("/i")
-          .arg(found_path)
+          .arg(msi_path_arg)
           .args(msiexec_args)
           .arg("/promptrestart")
           .spawn();