Skip to content

fix(bundler): Use escaped installer path when starting the updater setup, fixes #7931#7956

Merged
amrbashir merged 5 commits into1.xfrom
fix/updater-launch-arg
Oct 4, 2023
Merged

fix(bundler): Use escaped installer path when starting the updater setup, fixes #7931#7956
amrbashir merged 5 commits into1.xfrom
fix/updater-launch-arg

Conversation

@FabianLars
Copy link
Member

@FabianLars FabianLars commented Oct 4, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

fixes #7931

@FabianLars FabianLars requested a review from a team as a code owner October 4, 2023 17:43
@FabianLars
Copy link
Member Author

FabianLars commented Oct 4, 2023

do i have to downgrade the whole ecosystem now or what

@amrbashir amrbashir merged commit cdd5516 into 1.x Oct 4, 2023
@amrbashir amrbashir deleted the fix/updater-launch-arg branch October 4, 2023 21:45
FabianLars added a commit to tauri-apps/plugins-workspace that referenced this pull request Nov 15, 2023
@FabianLars
fix(updater): Use escaped installer path to start the nsis updater
cb76a5e 
Port of v1 change: tauri-apps/tauri#7956
@FabianLars FabianLars mentioned this pull request Nov 15, 2023
Merged
amrbashir pushed a commit to tauri-apps/plugins-workspace that referenced this pull request Nov 15, 2023
@FabianLars
fix(updater): Use escaped installer path to start the nsis updater (#727
9db40a6 
)

Port of v1 change: tauri-apps/tauri#7956
tauri-bot pushed a commit to tauri-apps/tauri-plugin-authenticator that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
0daea92 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-autostart that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
5ba8e0f 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-cli that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
f63e65a 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-clipboard-manager that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
942aa06 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-dialog that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
7dee7bd 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-fs that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
33fedbc 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-global-shortcut that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
a5c6c49 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-http that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
e16f36a 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-log that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
9ec9463 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-notification that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
f9cde6e 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-os that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
7e14bf2 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-positioner that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
e6ebf03 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-process that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
b44da23 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-shell that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
2c482c6 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-sql that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
e457cee 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-store that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
7309a1e 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-stronghold that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
6afa20b 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-updater that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
ff6f5a4 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-upload that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
00321d1 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-websocket that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
78d3202 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
tauri-bot pushed a commit to tauri-apps/tauri-plugin-window-state that referenced this pull request Nov 15, 2023
@FabianLars @amrbashir @tauri-bot
fix(updater): Use escaped installer path to start the nsis updater (#…
0826ca9 
…727)

Port of v1 change: tauri-apps/tauri#7956

Committed via a GitHub action: https://github.com/tauri-apps/plugins-workspace/actions/runs/6877612128

Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
amrbashir added a commit that referenced this pull request Nov 15, 2023
@amrbashir
fix(updater): Use escaped installer path when starting the updater msi
0425260 
Continuation of #7956
@amrbashir amrbashir mentioned this pull request Nov 15, 2023
Merged
13 tasks
amrbashir added a commit that referenced this pull request Nov 15, 2023
@amrbashir
fix(updater): Use escaped installer path when starting the updater msi (
4b6a602 
#8234)

* fix(updater): Use escaped installer path when starting the updater msi

Continuation of #7956

* fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Roadmap
Status: 🔎 In audit

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FabianLars @amrbashir