fix(core): revert #6680, remove default notification sound on Windows (#7229)

amrbashir · web-flow · commit 6afd34727f15 · 2023-06-17T09:18:16.000-03:00
fix(core): revert #6680, remove default notification sound on Windows
diff --git a/.changes/core-revet-windows-notification-default-sound.md b/.changes/core-revet-windows-notification-default-sound.md
@@ -0,0 +1,5 @@
+---
+'tauri': 'patch:bug'
+---
+
+Revert [#6680](https://github.com/tauri-apps/tauri/pull/6680) which added a default sound for notifications on Windows. This introduced inconsistency with other platforms that has silent notifications by default. In the upcoming releases, we will add support for modifying the notification sound across all platforms.
diff --git a/core/tauri/src/api/notification.rs b/core/tauri/src/api/notification.rs
@@ -119,9 +119,6 @@ impl Notification {
       {
         notification.app_id(&self.identifier);
       }
-
-      // will be parsed as a `::winrt_notification::Sound`
-      notification.sound_name("Default");
     }
     #[cfg(target_os = "macos")]
     {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'tauri': 'patch:bug'
 +---
++
 +Revert [#6680](https://github.com/tauri-apps/tauri/pull/6680) which added a default sound for notifications on Windows. This introduced inconsistency with other platforms that has silent notifications by default. In the upcoming releases, we will add support for modifying the notification sound across all platforms.
Original file line number	Diff line number	Diff line change
`@@ -119,9 +119,6 @@ impl Notification {`
`119`	`119`	`{`
`120`	`120`	`notification.app_id(&self.identifier);`
`121`	`121`	`}`
`122`		`-`
`123`		- // will be parsed as a `::winrt_notification::Sound`
`124`		`- notification.sound_name("Default");`
`125`	`122`	`}`
`126`	`123`	`#[cfg(target_os = "macos")]`
`127`	`124`	`{`