fix: sound for notifications on windows (fix #6652) by Lej77 · Pull Request #6680 · tauri-apps/tauri

Lej77 · 2023-04-11T19:15:45Z

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Yes, and the changes were approved in issue #___
No

Checklist

When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
I have added a convincing reason for adding this feature, if necessary

Other information

Fixes #6652 so that a sound is played when showing a notification on Windows 10.

I tested my changes using:

[patch.crates-io]
tauri = { git = "https://github.com/Lej77/tauri.git", branch = "patch-1"}

on a simple Tauri app and the fix seems to be working.

FabianLars · 2023-04-12T08:39:41Z

Thank you! Could you also add a change file similar to this one please? https://github.com/tauri-apps/tauri/blob/146a794cb696816854648d33e2124e82154c7b2f/.changes/core-sync-windows-metadata.md

Lej77 · 2023-04-12T11:42:13Z

I have added a change file now! I also removed some trailing space that caused the cargo fmt check to fail.

lucasfernog · 2023-05-24T17:15:42Z

@Lej77 we're now enforcing signed commits, can you rebase your PR signing all commits? https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Lej77 · 2023-05-24T19:02:00Z

@lucasfernog I have signed all commits now, is there anything else I need to do?

lucasfernog · 2023-05-24T19:03:23Z

Thank you so much!

Ref tauri-apps/tauri#6680

Co-authored-by: wusyong <wusyong@users.noreply.github.com> Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de> Co-authored-by: Lucas Nogueira <lucas@tauri.studio> Co-authored-by: Simon Hyll <hyllsimon@gmail.com> Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app> Co-authored-by: Lucas Nogueira <lucas@tauri.app> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.studio> Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: chip <chip@chip.sh> Co-authored-by: Raphii <iam@raphii.co> Co-authored-by: Ronie Martinez <ronmarti18@gmail.com> Co-authored-by: hanaTsuk1 <101488209+hanaTsuk1@users.noreply.github.com> Co-authored-by: nathan-fall <39990940+nathan-fall@users.noreply.github.com> Co-authored-by: Akshay <nerdy@peppe.rs> Co-authored-by: KurikoMoe <kurikomoe@gmail.com> Co-authored-by: Guilherme Oenning <me@goenning.net> Co-authored-by: Pierre Cashon <biaocy91@gmail.com> Co-authored-by: Jack Wills <32690432+mrjackwills@users.noreply.github.com> Co-authored-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com> Co-authored-by: Risto Stevcev <me@risto.codes> Co-authored-by: Soumt <rltks1305@naver.com> Co-authored-by: yutotnh <57719497+yutotnh@users.noreply.github.com> Co-authored-by: Gökçe Merdun <agmmnn@gmail.com> Co-authored-by: Nathanael Rea <Nathan@NathanaelRea.com> Co-authored-by: Usman Rajab <usman.rajab@gmail.com> Co-authored-by: Francis The Basilisk <36006338+snorkysnark@users.noreply.github.com> Co-authored-by: Lej77 <31554212+Lej77@users.noreply.github.com> Co-authored-by: Tomáš Diblík <dibla.tomas@post.cz> Co-authored-by: Jonas Kruckenberg <iterpre@protonmail.com> Co-authored-by: Pascal Sommer <Pascal-So@users.noreply.github.com> Co-authored-by: Bo <bertonzh@gmail.com> Co-authored-by: Kevin Yue <k3vinyue@gmail.com> fixed grammar and typos (#6937) Fix api.js docs pipeline with updated typedoc dependencies (#6945) closes #6887 (#6922) fix(core): Fix `WindowBuilder::on_navigation` handler never registerd, closes #6865 (#6921) fix(core): Fix `WindowBuilder::on_navigation` handler never registerd, closes #6865 fix broken symlinks in license files (#6336) fix(cli): fix cli connection timeout to dev server (fix #6045) (#6046) fix(bundler): ensure that there are no duplicate extension arguments when bundling on Windows, fixes #6103 (#6917) fix(bundler): ensure that there are no duplicate extension arguments during bundling on Windows (fix #6103) closes #5491 (#6408) fix(nsis): prefill $INSTDIR with previous install path and respect `/D` flag, closes #6928 (#6935) fix(nsis): prefill $INSTDIR with previous install path and respect `/D` flag, closes #6928 fix(updater): emit `UPTODATE` when server responds with 204, closes #6934 (#6970) fix(core): unpin all dependencies, closes #6944 (#6966) fix(bundler): Add new lang_file option in persian variant. (#6972) fix(core/ipc): access url through webview native object, closes #6889 (#6976) fix(core): remove trailing slash in http scope url, closes #5208 (#6974) fix(core): remove trailing slash in http scope url, closes #5208 fix(cli): find correct binary when `--profile` is used, closes #6954 (#6979) fix(cli): find correct binary when `--profile` is used, closes #6954 closes #6955 (#6987) closes #6955 closes #6158 (#6969) closes #6158 fix(cli): improve vs build tools detection (#6982) fix: updated appimage script to follow symlinks for /usr/lib* (fix: #6992) (#6996) fix(cli): correctly remove Cargo features (#7013) Fix typo (#7012) fix(cli): revert metadata.json field rename from #6795 (#7029) closes #6732 (#6736) fix: add missing file properties on Windows, closes #6676 (#6693) fix(cli.js): detect node-20 binary (#6667) fix version-or-publish workflow (#7031) fix(cli/devserver): inject autoreload into HTML only, closes #6997 (#7032) fix(bundler/nsis): write installer templates UTF16LE encoded, closes #7036 (#7040) fix(bundler/nsis): write installer templates UTF16LE encoded, closes #7036 fix(core): rewrite `asset` protocol streaming, closes #6375 (#6390) closes #5939 (#5960) fix(core): use `safe_block_on` (#7047) closes #6859 (#6933) closes #6955 (#6998) fix(core): populate webview_attrs from config, closes #6794 (#6797) closes #5176 (#5180) fix: sound for notifications on windows (fix #6652) (#6680) close native window's buttons, closes #2353 (#6665) fix(bundler/nsis): calculate accurate app size, closes #7056 (#7057) fix(tests): only download update when it is available (#7061) closes #6706 (#6712) fix(doc): correct the doc of `content_protected()` (#7065) closes #6472 (#6530) fix(macros): use full path to Result to avoid issues with type aliases (#7071)

ref: #7210

…#7229) fix(core): revert #6680, remove default notification sound on Windows

Lej77 requested a review from a team as a code owner April 11, 2023 19:15

FabianLars approved these changes Apr 12, 2023

View reviewed changes

wusyong assigned tweidinger May 1, 2023

lucasfernog requested a review from a team May 22, 2023 14:41

lucasfernog approved these changes May 24, 2023

View reviewed changes

Lej77 added 3 commits May 24, 2023 20:30

fix: sound for notifications on windows (fix #6652)

8f6b142

style: remove trailing spaces

2a0d9af

add change file

41cbb00

lucasfernog added a commit to tauri-apps/plugins-workspace that referenced this pull request May 24, 2023

feat(notification): play default sound on WIndows

7d71ad4

Ref tauri-apps/tauri#6680

lucasfernog mentioned this pull request May 24, 2023

feat(notification): play default sound on Windows tauri-apps/plugins-workspace#401

Merged

lucasfernog merged commit 65fd674 into tauri-apps:dev May 24, 2023

Lej77 deleted the patch-1 branch May 24, 2023 20:40

wusyong added the security: needs audit This issue/PR needs a security audit label May 25, 2023

qu1ck mentioned this pull request Jun 15, 2023

[feat] Windows default notification sound should be optional #7210

Closed

chippers added security: reviewed This issue/PR has been review by wg-security and removed security: needs audit This issue/PR needs a security audit labels Jun 15, 2023

amrbashir added a commit that referenced this pull request Jun 17, 2023

fix(core): revert #6680, remove default notification sound on Windows

5b4d5e7

ref: #7210

lucasfernog pushed a commit that referenced this pull request Jun 17, 2023

fix(core): revert #6680, remove default notification sound on Windows (…

6afd347

…#7229) fix(core): revert #6680, remove default notification sound on Windows

github-actions bot mentioned this pull request Jun 17, 2023

Apply Version Updates From Current Changes (v1) #7234

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: sound for notifications on windows (fix #6652)#6680

fix: sound for notifications on windows (fix #6652)#6680
lucasfernog merged 3 commits intotauri-apps:devfrom
Lej77:patch-1

Lej77 commented Apr 11, 2023 •

edited

Loading

Uh oh!

FabianLars commented Apr 12, 2023 •

edited

Loading

Uh oh!

Lej77 commented Apr 12, 2023 •

edited

Loading

Uh oh!

lucasfernog commented May 24, 2023

Uh oh!

Lej77 commented May 24, 2023

Uh oh!

lucasfernog commented May 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Lej77 commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Checklist

Other information

Uh oh!

FabianLars commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lej77 commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucasfernog commented May 24, 2023

Uh oh!

Lej77 commented May 24, 2023

Uh oh!

lucasfernog commented May 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Lej77 commented Apr 11, 2023 •

edited

Loading

FabianLars commented Apr 12, 2023 •

edited

Loading

Lej77 commented Apr 12, 2023 •

edited

Loading