Skip to content

Commit

Permalink
fix(bundler): Use escaped installer path when starting the updater se…
Browse files Browse the repository at this point in the history
…tup, fixes #7931 (#7956)

* fix(bundler): Use escaped installer path when starting the updater setup, fixes #7931

* fun ci stuff

* who needs lockfiles anyway

* stahp

* please let it be the last one. i want to leave
  • Loading branch information
FabianLars committed Oct 4, 2023
1 parent 19249d7 commit cdd5516
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changes/updater-launch-setup.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'tauri-bundler': 'patch:bug'
---

Fixes an app crash on app updates when the product name contained spaces.
4 changes: 3 additions & 1 deletion .github/workflows/test-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,9 @@ jobs:
- name: Downgrade crates with MSRV conflict
# The --precise flag can only be used once per invocation.
run: |
cargo update -p system-deps:6.1.2 --precise 6.1.1
cargo update -p toml:0.7.8 --precise 0.7.3
cargo update -p toml_edit --precise 0.19.8
cargo update -p toml_edit:0.19.15 --precise 0.19.8
cargo update -p toml_datetime --precise 0.6.1
cargo update -p serde_spanned --precise 0.6.1
cargo update -p winnow --precise 0.4.1
Expand All @@ -107,6 +108,7 @@ jobs:
cargo update -p cfg-expr:0.15.5 --precise 0.15.4
cargo update -p memchr --precise 2.6.2
cargo update -p async-executor --precise 1.5.1
cargo update -p proptest --precise 1.2.0
- name: test
run: cargo test --target ${{ matrix.platform.target }} ${{ matrix.features.args }}
2 changes: 1 addition & 1 deletion core/tauri/src/updater/core.rs
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ fn copy_files_and_run<R: Read + Seek>(
Command::new(powershell_path)
.args(["-NoProfile", "-WindowStyle", "Hidden"])
.args(["Start-Process"])
.arg(found_path)
.arg(installer_arg)
.arg("-ArgumentList")
.arg(
[
Expand Down

0 comments on commit cdd5516

Please sign in to comment.