Skip to content

Commit

Permalink
fix: recommended run dev command in create-tauri-app (#2555)
Browse files Browse the repository at this point in the history
`--dev` is not a valid option for `tauri` cli; instead, we should use
`-- dev` or just `dev`. Also, we can just use `tauri dev` for all
package managers so we don't need to do the npm checking.
  • Loading branch information
CYBAI committed Aug 30, 2021
1 parent 2ec998b commit f2865fa
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 18 deletions.
4 changes: 1 addition & 3 deletions tooling/create-tauri-app/src/recipes/dominator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ export const dominator: Recipe = {
$ cd ${cfg.appName}
$ ${packageManager} install
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${
packageManager === 'npm' ? '--' : ''
}dev
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev
`)
return await Promise.resolve()
}
Expand Down
4 changes: 1 addition & 3 deletions tooling/create-tauri-app/src/recipes/ng-cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ const ngcli: Recipe = {
Your installation completed.
$ cd ${cfg.appName}
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${
packageManager === 'npm' ? '--' : ''
}dev
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev
`)

return await Promise.resolve()
Expand Down
4 changes: 1 addition & 3 deletions tooling/create-tauri-app/src/recipes/react.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,7 @@ export const cra: Recipe = {
Your installation completed.
$ cd ${cfg.appName}
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${
packageManager === 'npm' ? '--' : ''
}dev
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev
`)
return await Promise.resolve()
}
Expand Down
4 changes: 1 addition & 3 deletions tooling/create-tauri-app/src/recipes/svelte.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@ const svelte: Recipe = {
$ cd ${cfg.appName}
$ ${packageManager} install
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${
packageManager === 'npm' ? '--' : ''
}dev
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev
`)

return await Promise.resolve()
Expand Down
4 changes: 1 addition & 3 deletions tooling/create-tauri-app/src/recipes/vanilla.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ export const vanillajs: Recipe = {
$ cd ${cfg.appName}
$ ${packageManager} install
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${
packageManager === 'npm' ? '--' : ''
}dev
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev
`)
return await Promise.resolve()
}
Expand Down
4 changes: 1 addition & 3 deletions tooling/create-tauri-app/src/recipes/vite.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,7 @@ const vite: Recipe = {
Your installation completed.
$ cd ${cfg.appName}
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri ${
packageManager === 'npm' ? '--' : ''
}dev
$ ${packageManager === 'npm' ? 'npm run' : packageManager} tauri dev
`)
return await Promise.resolve()
}
Expand Down

0 comments on commit f2865fa

Please sign in to comment.