Fix recommended run dev command in create-tauri-app #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <wusyong9104@gmail.com>
`--dev` is not a valid option for `tauri` cli; instead, we should use `-- dev` or just `dev`. Also, we can just use `tauri dev` for all package managers so we don't need to do the npm checking.
|
@wusyong could you please help me check this PR? 🙏 I've confirmed it locally and the screenshot is in the PR description. thank you! |
amrbashir
requested changes
Aug 30, 2021
There was a problem hiding this comment.
Thanks for the PR, but please keep the double-dash when npm is used, because in some npm versions (I think npm v6), it will fail without it.
The fix should be to just add a space after the double-dash, so '--' should be '-- '
Edit: I was wrong -- is only need when additional arguments like --ci so your PR is fine
amrbashir
approved these changes
Aug 30, 2021
wusyong
approved these changes
Aug 30, 2021
|
@amrbashir thank you so much for your confirmation! 🙏 and thanks for quick review from both of you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--devis not a valid option fortauricli; instead, we should use-- devor justdev. Also, we can just usetauri devfor allpackage managers so we don't need to do the npm checking.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: