Skip to content

fix(api): distribution#1582

Merged
lucasfernog merged 4 commits into
devfrom
fix/api-package
Apr 22, 2021
Merged

fix(api): distribution#1582
lucasfernog merged 4 commits into
devfrom
fix/api-package

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner April 22, 2021 14:44
@lucasfernog lucasfernog requested a review from a team April 22, 2021 14:44
@nothingismagick

Copy link
Copy Markdown
Member

Don't we have to ship the typings? And can we please ship the .ts as well?

@lucasfernog

Copy link
Copy Markdown
Member Author

Don't we have to ship the typings? And can we please ship the .ts as well?

We are shipping the typings on the dist folder. I'll copy the ts files.

Comment thread tooling/api/package.json Outdated
Co-authored-by: Amr Bashir <48618675+amrbashir@users.noreply.github.com>
@lucasfernog lucasfernog merged commit 7f998d0 into dev Apr 22, 2021
@lucasfernog lucasfernog deleted the fix/api-package branch April 22, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants