Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: asset custom protocol to access local file system #2104

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jun 28, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fix #2103

Which feature flag should this feature put behind btw?

@wusyong wusyong requested a review from a team as a code owner June 28, 2021 13:25
@wusyong wusyong requested a review from a team June 28, 2021 13:25
@lucasfernog
Copy link
Member

We need to decide where to document this.

@wusyong
Copy link
Member Author

wusyong commented Jun 28, 2021

Where do we put the documents about loading assets. Perhaps it should put there too.

@lucasfernog
Copy link
Member

We need to create one lol. Good thing it's documentation month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for accessing files from local filesystem with in html
3 participants