-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli.rs): pnpm tauri info exits with error (fix #2509) #2510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, can you remove vfs
dependency and use normal std::fs
instead? seems to me it is not necessary to add vfs
@amrbashir I made the recommended changes. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, The PR looks good to me but it might take a sometime to merge.
@amrbashir I updated the code to default to npm when no lock files exists since that was the behavior before my change. |
Nice, you basically read my mind. |
Is there a way to get the next branch working in a new project I am working on? Or maybe release the current #next branch to the next version on NPM? I am wondering cause it seems there are a lot of improvements since the latest beta release in august. |
@chrisspiegl For the According to our release plans/guidelines, there won't be any next-only releases to npm and that wouldn't be enough anyway because the prebuilt clis (needed by the npm package) are pulled from a seperate github page. |
Thank you for clearing that up. I will try the cargo based cli. For anyone wondering, I had to fix the
now I can run |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: