Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macOS): Add AppHandle::show() and AppHandle::hide() #2825

Closed
wants to merge 12 commits into from
Closed

feat(macOS): Add AppHandle::show() and AppHandle::hide() #2825

wants to merge 12 commits into from

Conversation

probablykasper
Copy link
Member

@probablykasper probablykasper commented Oct 30, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Exposes macOS-only show_application and hide_application from tao.

@probablykasper probablykasper requested a review from a team as a code owner October 30, 2021 04:03
@probablykasper probablykasper requested review from a team October 30, 2021 04:03
.changes/mac-app-hide.md Outdated Show resolved Hide resolved
@probablykasper probablykasper changed the title feat(macOS): Add AppHandle::hide() feat(macOS): Add AppHandle::show() and AppHandle::hide() Dec 7, 2021
@probablykasper
Copy link
Member Author

@amrbashir Any idea why the build-artifacts action is failing, or how to go about fixing it? The EventLoopWindowTargetExtMacOS trait is imported, and app_handle.show() does work when I run tauri dev.

error[E0599]: no method named `show_application` found for reference `&EventLoopWindowTarget<Message>` in the current scope
    --> /Users/runner/work/tauri/tauri/core/tauri-runtime-wry/src/lib.rs:1952:20
     |
1952 |         event_loop.show_application();
     |                    ^^^^^^^^^^^^^^^^ method not found in `&EventLoopWindowTarget<Message>`

@amrbashir
Copy link
Member

don't know really, but I think the updater-test-artifacts workflow has been broken for a while. @lucasfernog might have a better idea.

@probablykasper
Copy link
Member Author

@amrbashir @lucasfernog either of you wanna give this one a look so it can be merged?

@lucasfernog
Copy link
Member

@amrbashir @lucasfernog either of you wanna give this one a look so it can be merged?

I think this one will need to wait for v2.

@probablykasper probablykasper requested review from a team February 13, 2022 00:06
@probablykasper probablykasper changed the base branch from next to dev February 13, 2022 00:32
@probablykasper
Copy link
Member Author

Opened PR #3689 instead, from a different branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: core Core packages of Tauri
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants