Skip to content

feat(core): expose functions to serialize serde::Serialize values to JS#3354

Merged
lucasfernog merged 5 commits into
nextfrom
feat/expose-ipc-format
Feb 7, 2022
Merged

feat(core): expose functions to serialize serde::Serialize values to JS#3354
lucasfernog merged 5 commits into
nextfrom
feat/expose-ipc-format

Conversation

@lucasfernog
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner February 7, 2022 18:15
@lucasfernog lucasfernog requested a review from a team February 7, 2022 18:15
@lucasfernog
Copy link
Copy Markdown
Member Author

This functionality is currently copy-pasted on some of our plugins, and is also helpful to any userland app using window.eval passing serde::Serialize values.

@lucasfernog lucasfernog changed the title feat(core): expose api::ipc::format_json_parse feat(core): expose api::ipc::format_json Feb 7, 2022
@lucasfernog lucasfernog changed the title feat(core): expose api::ipc::format_json feat(core): expose functions to serialize serde::Serialize values to JS Feb 7, 2022
@lucasfernog lucasfernog merged commit 5a94200 into next Feb 7, 2022
@lucasfernog lucasfernog deleted the feat/expose-ipc-format branch February 7, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant