Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate windows resource directories using resource_relpath, closes #4087. #4111

Merged
merged 2 commits into from
May 13, 2022
Merged

fix: generate windows resource directories using resource_relpath, closes #4087. #4111

merged 2 commits into from
May 13, 2022

Conversation

gimait
Copy link
Contributor

@gimait gimait commented May 13, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@gimait gimait requested a review from a team May 13, 2022 04:10
@gimait gimait changed the title fix: generate windows resource directories using relative path conventions, closes #4087. fix: generate windows resource directories using resource_relpath, closes #4087. May 13, 2022
@gimait gimait requested a review from a team as a code owner May 13, 2022 12:55
lucasfernog
lucasfernog approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lucasfernog lucasfernog merged commit 787ea09 into tauri-apps:dev May 13, 2022
dceddia pushed a commit to dceddia/tauri that referenced this pull request May 14, 2022
@gimait @lucasfernog @dceddia
fix: generate windows resource directories using resource_relpath, cl…
cde74eb 
…oses tauri-apps#4087. (tauri-apps#4111)

Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gimait @lucasfernog