Skip to content

fix(core): update metadata before window-created listeners, closes #5191#5458

Merged
lucasfernog merged 1 commit intodevfrom
fix/metadata-update
Oct 22, 2022
Merged

fix(core): update metadata before window-created listeners, closes #5191#5458
lucasfernog merged 1 commit intodevfrom
fix/metadata-update

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Tauri fires event listeners in reverse order, so our own tauri://window-created listener is the last to execute. This commit changes the listen JS code to keep our own listener as the last one in the array, so the metadata is updated before user code is executed.



Tauri fires event listeners in reverse order, so our own tauri://window-created listener is the last to execute. This commit changes the listen JS code to keep our own listener as the last one in the array, so the metadata is updated before user code is executed.
@lucasfernog lucasfernog requested a review from a team as a code owner October 21, 2022 14:33
@lucasfernog lucasfernog merged commit e00b1e5 into dev Oct 22, 2022
@lucasfernog lucasfernog deleted the fix/metadata-update branch October 22, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant