fix(core): Invoke event listener in windows safely to avoid causing uncaught errors in windows that have loaded external urls #5563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a tauri window with an External URL, events sent with
emit_all
, including internal events liketauri://window-created
, are still delivered.Since these windows have not loaded the necessary code, the invocation fails and causes an uncaught javascript error in the window's webview.
Functionally speaking, this is fine, but it's not very neat and has some noticeable effects:
This PR adds a simple safeguard that checks that the listener function exists before calling it.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
Implementation approach briefly discussed here: https://discord.com/channels/616186924390023171/986184094050316358/1038527853236592661