feat: Use the zbus-backed of notify-rust #6332

zeenix · 2023-02-21T12:52:35Z

While zbus used to have too new MSRV, that is no longer the case for several months now and hence there is no good reason to avoid zbus dependency. The MSRV is tracked in the zbus CI even to avoid any accidental bumps. The MSRV of zbus is 1.60 currently, which is only 1 version above the MSRV of dbus-rs. Neither Rust 1.60 nor 1.59 is available in Ubuntu LTS or Debian unstable so this change doesn't introduce any distro issues AFAICT.

OTOH, using zbus eliminates dependency on a platform lib and hence enhances the portability and ease of building. Issues like these will be a thing of the past after this change:

#4373
#5007
#5466

Moreover, the latest release of notify-rust enables async APIs based on zbus' async support, in case that is useful for Tauri project in the future.

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Yes, and the changes were approved in issue #___
No

Checklist

When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
I have added a convincing reason for adding this feature, if necessary

Other information

While zbus used to have too new MSRV, that is no longer the case for several months now and hence there is no good reason to avoid zbus dependency. The MSRV is tracked in the zbus CI even to avoid any accidental bumps. OTOH, using zbus eliminates dependency on a platform lib and hence enhances the portability and ease of building. Issues like these will be a thing of the past after this change: tauri-apps#4373 tauri-apps#5007 tauri-apps#5466

FabianLars · 2023-02-21T12:59:02Z

The MSRV of zbus is 1.60 currently

That unfortunately is too new. We are stuck with 1.59 on Tauri v1.X - i can't remember what we used to determine that version, maybe what some debian version used to build firefox(?) and even though they raised their version above 1.59 too we can't change our msrv policy in a minor release. or at least didn't want to the last time we talked about it.

That said, this change would be fine on the next branch where we will likely change the MSRV policy to something like "last X versions, updated on each minor release"

Edit: Depending on how long we want to keep releasing 1.X version we should probably discuss the msrv again, but it looks like we will focus more on 2.0 than minor releases 🤔

zeenix · 2023-02-21T15:33:46Z

That unfortunately is too new. We are stuck with 1.59 on Tauri v1.X - i can't remember what we used to determine that version,

Well to be fair, that was also quite new at some point so I'm sure there was a very good reason. :)

maybe what some debian version used to build firefox(?) and even though they raised their version above 1.59 too we can't change our msrv policy in a minor release. or at least didn't want to the last time we talked about it.

IMO that seems a bit too strict. Not bumping MSRV in a patch release (e.g what time crate recently did) would be not only understandable, it would be a good policy. While strictly speaking MSRV bump is a (potentially) breaking change, as we know, not all breaking changes are major.

But it's your project so your rules. :)

That said, this change would be fine on the next branch where we will likely change the MSRV policy to something like "last X versions, updated on each minor release"

Edit: Depending on how long we want to keep releasing 1.X version we should probably discuss the msrv again, but it looks like we will focus more on 2.0 than minor releases thinking

I understand. It all depends on your project's priorities. I would only suggest humbly that you consider an MSRV bump. Perhaps bumping only by 1 version (1.60) for now then switch to the new MSRV policy after 2.0?

amrbashir · 2023-02-21T23:57:12Z

I think it should be fine to bump the MSRV in a minor release and 1.60 is almost 1 year old, that's old enough.

zeenix · 2023-02-22T00:32:57Z

@amrbashir cool. Should I bump the MSRV as part of this PR?

amrbashir · 2023-02-22T01:04:28Z

Fine by me but I'd rather wait for @lucasfernog to approve this first.

lucasfernog · 2023-02-22T13:16:05Z

MSRV 1.60 would also allow us to bump another dependency (serde-with IIRC) so it would be nice. But I'd like to hear from @chippers.

FabianLars · 2023-02-22T13:20:43Z

i mean, i'm all for a msrv bump (my first message was not my opinion but a summary of our past 100 discussions about this), but we should at least clearly communicate this, preferably (long) before actually releasing a new tauri version with it and not just via a small mention in the release notes on release day. Just because we were super strict about this so far in 1.X 🤷

We could then also use this chance for a teaser about the MSRV policy changes in v2 to ease users into that.

zeenix · 2023-02-22T13:35:10Z

but we should at least clearly communicate this, preferably (long) before actually releasing a new tauri version with it and not just via a small mention in the release notes on release day. Just because we were super strict about this so far in 1.X shrug

Fair enough. Anything I can help with? Should I bump the MSRV in the PR and then you folks handle the rest?

chippers · 2023-02-23T20:11:35Z

One of the reasons why 1.59 is the magic number we settled on was that Debian packages 1.59in their stable release for Firefox, and they have a policy that packages must be built by the other packages in that release. Our goal was to hopefully make it easier for Tauri applications to make it into Debian in the future, and this is just the current stable version. Unfortunately, Debian has entered their first soft freeze for the next release and that rustc version is only 1.63which means we will miss out on some good stuff like workspace dependency inheritance.

Usually when a package maintainer commits to packaging an application, it would be up to them to freeze dependencies and create patches to satisfy the MSRV requirements, but we wanted it to be dead easy for a Tauri application to be able to be accepted.

It's not a permanent solution, just our general goal to allow easier packaging and more likelihood a Tauri app would be packaged.

If we can improve our Linux distribution stuff then this matters a lot less. Once we can have e.g. flatpaks working very well and perhaps an easier way for generating 3rd party repos (like how installing some packages will actually add their own apt repository and pull the packages from there) I think we would be in a much better spot to adopt a stable - Xpolicy.

Since no new packages can make it into current or next stable, perhaps we just adopt testing's version for now (and upgrade as it upgrades) until we decide what to do later.

chippers · 2023-02-23T20:16:35Z

@lucasfernog ^

zeenix · 2023-02-28T13:28:31Z

Ping? ☺️

chippers · 2023-03-01T06:46:53Z

Ping? ☺️

Lucas is taking a break right now, so a decision will likely take a bit of time

lucasfernog · 2023-03-16T12:12:29Z

I feel like we should discuss the MSRV bump with the rest of the community.

zeenix · 2023-03-17T12:35:57Z

I feel like we should discuss the MSRV bump with the rest of the community.

Tbh, I was hoping you'd just be the last approver to bumping and we can finally get this landed, but sure. Please let me know how I can help with that.

zeenix · 2023-03-31T13:24:44Z

I feel like we should discuss the MSRV bump with the rest of the community.

How is that going?

zeenix · 2023-03-31T15:27:42Z

thanks @lucasfernog

zeenix requested a review from a team as a code owner February 21, 2023 12:52

FabianLars mentioned this pull request Mar 13, 2023

fix(core/tauri): upgrade open to 3.2 to fix a bug on Windows #6441

Merged

13 tasks

set msrv to 1.60

b4f9490

lucasfernog requested a review from a team as a code owner March 31, 2023 13:44

lucasfernog added 2 commits March 31, 2023 10:51

unpin os_info

99f1183

remove unarray

4d09c30

lucasfernog approved these changes Mar 31, 2023

View reviewed changes

lucasfernog merged commit 5fdc616 into tauri-apps:dev Mar 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Use the zbus-backed of notify-rust #6332

feat: Use the zbus-backed of notify-rust #6332

zeenix commented Feb 21, 2023 •

edited

Loading

FabianLars commented Feb 21, 2023 •

edited

Loading

zeenix commented Feb 21, 2023

amrbashir commented Feb 21, 2023 •

edited

Loading

zeenix commented Feb 22, 2023

amrbashir commented Feb 22, 2023

lucasfernog commented Feb 22, 2023

FabianLars commented Feb 22, 2023 •

edited

Loading

zeenix commented Feb 22, 2023

chippers commented Feb 23, 2023 •

edited

Loading

chippers commented Feb 23, 2023

zeenix commented Feb 28, 2023

chippers commented Mar 1, 2023

lucasfernog commented Mar 16, 2023

zeenix commented Mar 17, 2023

zeenix commented Mar 31, 2023

zeenix commented Mar 31, 2023

feat: Use the zbus-backed of notify-rust #6332

feat: Use the zbus-backed of notify-rust #6332

Conversation

zeenix commented Feb 21, 2023 • edited Loading

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Checklist

Other information

FabianLars commented Feb 21, 2023 • edited Loading

zeenix commented Feb 21, 2023

amrbashir commented Feb 21, 2023 • edited Loading

zeenix commented Feb 22, 2023

amrbashir commented Feb 22, 2023

lucasfernog commented Feb 22, 2023

FabianLars commented Feb 22, 2023 • edited Loading

zeenix commented Feb 22, 2023

chippers commented Feb 23, 2023 • edited Loading

chippers commented Feb 23, 2023

zeenix commented Feb 28, 2023

chippers commented Mar 1, 2023

lucasfernog commented Mar 16, 2023

zeenix commented Mar 17, 2023

zeenix commented Mar 31, 2023

zeenix commented Mar 31, 2023

zeenix commented Feb 21, 2023 •

edited

Loading

FabianLars commented Feb 21, 2023 •

edited

Loading

amrbashir commented Feb 21, 2023 •

edited

Loading

FabianLars commented Feb 22, 2023 •

edited

Loading

chippers commented Feb 23, 2023 •

edited

Loading