[feat] Add Persian as available languages for NSIS installers.#6965
Merged
wusyong merged 1 commit intotauri-apps:devfrom May 16, 2023
Merged
[feat] Add Persian as available languages for NSIS installers.#6965wusyong merged 1 commit intotauri-apps:devfrom
wusyong merged 1 commit intotauri-apps:devfrom
Conversation
Contributor
Author
Should I do anything for Merging Block ? |
Member
|
Oh yeah, you need to setup commit signing, then you can sign past commit like this for example. I really wish github would complain about missing signatures more prominently, so it's easier to spot before approving a PR 😅 |
Contributor
Author
|
I did . Thanks for your guide . |
Member
|
The first commit is still unsigned so you have to try my second link again (if you use the top answer, replace I really wish this part wouldn't be that finicky, it's really unfriendly for new contributors :/ |
517293f to
55d6aeb
Compare
55d6aeb to
1e47910
Compare
Contributor
Author
|
@FabianLars |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Relevant issue: #6906
Relevant PR: #6940