-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add Persian as available languages for NSIS installers. #6965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Should I do anything for Merging Block ? |
Oh yeah, you need to setup commit signing, then you can sign past commit like this for example. I really wish github would complain about missing signatures more prominently, so it's easier to spot before approving a PR 😅 |
I did . Thanks for your guide . |
The first commit is still unsigned so you have to try my second link again (if you use the top answer, replace I really wish this part wouldn't be that finicky, it's really unfriendly for new contributors :/ |
517293f
to
55d6aeb
Compare
55d6aeb
to
1e47910
Compare
@FabianLars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again :D
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
Relevant issue: #6906
Relevant PR: #6940