Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add Persian as available languages for NSIS installers. #6965

Merged
merged 1 commit into from
May 16, 2023

Conversation

Mehrbod2002
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Relevant issue: #6906
Relevant PR: #6940

FabianLars
FabianLars previously approved these changes May 15, 2023
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Mehrbod2002 Mehrbod2002 changed the title Add Persian to supported NSIS languages [feat] Add Persian as available languages for NSIS installers. May 15, 2023
@Mehrbod2002
Copy link
Contributor Author

Thank you!

Should I do anything for Merging Block ?

@FabianLars
Copy link
Member

Oh yeah, you need to setup commit signing, then you can sign past commit like this for example.

I really wish github would complain about missing signatures more prominently, so it's easier to spot before approving a PR 😅

@Mehrbod2002
Copy link
Contributor Author

Mehrbod2002 commented May 15, 2023

@FabianLars

I did . Thanks for your guide .

@FabianLars
Copy link
Member

The first commit is still unsigned so you have to try my second link again (if you use the top answer, replace development with dev like: git rebase --exec 'git commit --amend --no-edit -n -S' -i dev) and then force push via git push --force to overwrite the remote branch ;)

I really wish this part wouldn't be that finicky, it's really unfriendly for new contributors :/

@Mehrbod2002
Copy link
Contributor Author

@FabianLars
I reseted and pushed as a new commti

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again :D

@wusyong wusyong merged commit 21d5eb8 into tauri-apps:dev May 16, 2023
@Mehrbod2002 Mehrbod2002 deleted the nsis-persian-support branch May 16, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

3 participants