Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: renamed TrayIconBuilder/TrayIcon::on_tray_event to TrayIconBuilder/TrayIcon::on_tray_icon_event #7943

Merged
merged 1 commit into from
Oct 3, 2023
Merged

refactor!: renamed TrayIconBuilder/TrayIcon::on_tray_event to TrayIconBuilder/TrayIcon::on_tray_icon_event #7943

merged 1 commit into from
Oct 3, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Oct 2, 2023 •
edited

ref: #7756

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir
refactor!: renamed TrayIconBuilder/TrayIcon::on_tray_event to `Tray…
7f433d6 
…IconBuilder/TrayIcon::on_tray_icon_event`

ref: #7756
@amrbashir amrbashir requested a review from a team as a code owner October 2, 2023 23:10
@amrbashir amrbashir mentioned this pull request Oct 2, 2023
Closed
14 tasks
@lucasfernog lucasfernog merged commit c0d03af into dev Oct 3, 2023
22 checks passed
@lucasfernog lucasfernog deleted the refactor/on-tray-event branch October 3, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @lucasfernog