Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): update template with permissions and capabilities #8666

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

lucasfernog
Copy link
Member

No description provided.

@lucasfernog lucasfernog requested a review from a team as a code owner January 24, 2024 14:33
"window:default",
"webview:default",
"app:default",
"resources:default",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to enable this by default? or better can menu:default and tray:default include this permission? because resources is kinda internal and users should not need to deal with it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now there's no way for a plugin to enable commands on other plugins.. but we can adapt core to ignore permission checks for the resources plugin worst case

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that for a security reason or just not implemented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't make much sense really.. but i can include a set of permissions that are enabled by default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can include all core plugin default permissions automatically.. then the user can deny the functions he doesn't want.. what do you think @chippers

@lucasfernog lucasfernog merged commit f492efd into dev Feb 1, 2024
3 checks passed
@lucasfernog lucasfernog deleted the feat/update-cli-template-permissions branch February 1, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants