Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add app-region: drag to data-tauri-drag-region #9789

Merged
merged 6 commits into from
May 22, 2024
Merged

feat(core): add app-region: drag to data-tauri-drag-region #9789

merged 6 commits into from
May 22, 2024

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented May 15, 2024 •
edited
Loading

Use app-region: drag on supported platforms (currently only WebView2 123+ on Windows)

@Legend-Master Legend-Master changed the title Add app-region: drag to data-tauri-drag-region feat(core): add app-region: drag to data-tauri-drag-region May 21, 2024
@Legend-Master Legend-Master marked this pull request as ready for review May 21, 2024 06:51
@Legend-Master Legend-Master requested a review from a team as a code owner May 21, 2024 06:51
amrbashir
amrbashir requested changes May 22, 2024
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to get the webview version and embed it into this script at startup then disable the custom JS handler on Windows when using WebView2 123+

core/tauri/src/window/scripts/drag.js Outdated Show resolved Hide resolved
@Legend-Master
Copy link
Contributor Author

Legend-Master commented May 22, 2024 •
edited
Loading

We probably need to get the webview version and embed it into this script at startup then disable the custom JS handler on Windows when using WebView2 123+

I don't think we need to, we won't get events in non client region, so if app-region: drag is working, it should just skip the other handlers

@amrbashir
Copy link
Member

We probably need to get the webview version and embed it into this script at startup then disable the custom JS handler on Windows when using WebView2 123+

I don't think we need to, we won't get events in non client region, so if app-region: drag is working, it should just skip the other handlers

That's enough I guess

amrbashir
amrbashir requested changes May 22, 2024
View reviewed changes
.changes/app-region-drag.md Outdated Show resolved Hide resolved
Legend-Master and others added 2 commits May 22, 2024 11:13
@Legend-Master @amrbashir
Apply suggestions from code review
189d4c3 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@Legend-Master
lock file in api example
a7cc003
@amrbashir amrbashir merged commit ae6b13d into tauri-apps:dev May 22, 2024
19 checks passed
@Legend-Master Legend-Master deleted the app-region branch May 23, 2024 02:30
amrbashir added a commit that referenced this pull request May 23, 2024
@amrbashir
Revert "feat(core): add app-region: drag to data-tauri-drag-region (
ab326a9 
#9789)"

This reverts commit ae6b13d.
lucasfernog pushed a commit that referenced this pull request May 29, 2024
@amrbashir
Revert "feat(core): add app-region: drag to data-tauri-drag-region (
dfd0544 
#9789)" (#9860)

* Revert "feat(core): add `app-region: drag` to `data-tauri-drag-region` (#9789)"

This reverts commit ae6b13d.

* Update pre.json

* change files

* Discard changes to .changes/pre.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Legend-Master @amrbashir