-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support webview proxy #1006
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are we able to check macos version during runtime? |
pewsheen
commented
Aug 16, 2023
For runtime os version check, we can use isOperatingSystemAtLeastVersion |
amrbashir
requested changes
Aug 16, 2023
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
pewsheen
commented
Aug 17, 2023
amrbashir
previously approved these changes
Aug 17, 2023
amrbashir
approved these changes
Aug 17, 2023
2 tasks
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Dec 20, 2023
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Dec 20, 2023
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Dec 20, 2023
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Dec 21, 2023
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Dec 21, 2023
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Dec 21, 2023
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Dec 25, 2023
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Dec 29, 2023
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Jan 3, 2024
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Jan 3, 2024
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Jan 3, 2024
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
time-river
added a commit
to time-river/tauri
that referenced
this pull request
Jan 5, 2024
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
lucasfernog
added a commit
to tauri-apps/tauri
that referenced
this pull request
Feb 1, 2024
* feat(wry): support proxy in wry runtime wry has been supported http/socks5 proxy in [#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me> * Apply suggestions from code review * Apply suggestions from code review * Update core/tauri-runtime-wry/src/lib.rs * Update core/tauri/src/window/mod.rs * add macos-proxy flag * add change file * delete file * update change file * use macos-14 runner to test core --------- Signed-off-by: lin fu <river@vvl.me> Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com> Co-authored-by: Lucas Nogueira <lucas@tauri.studio> Co-authored-by: Lucas Nogueira <lucas@tauri.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information
Status: Draft
Todo:
Support proxy types
We're not ready to support authentications and custom TLS configuration for proxy at this stage
Also, the API provided by wkwebview is still in Beta, which means it requires macOS 14.0+