Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/impl wkwebview file upload panel, closes #305 #545

Merged
merged 2 commits into from
Apr 10, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Apr 8, 2022

I fixed #305.

In this PR, file upload panel will be supported on MacOS.
Including the following features:

  • We can select a file when webview get request like <input type=file>.
  • We can select multiple files when webview get request like <input type=file multiple>.
  • We can select a directory when webview get request like <input type=file webkitdirectory>.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@keiya01 keiya01 requested review from a team April 8, 2022 00:26
@keiya01 keiya01 force-pushed the feat/impl-wkwebview-file-upload-panel branch from aca60eb to 0f83567 Compare April 8, 2022 00:31
@keiya01 keiya01 changed the title Feat/impl wkwebview file upload panel Feat/impl wkwebview file upload panel, closes #305 Apr 8, 2022
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it and it's looking great!
Really appreciate your effort. These requests are usually difficult to resolve.

@lucasfernog
Copy link
Member

Wow nice addition, I was going to write this now lol missed it because you guys forgot about the change file :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support file explorer using html
3 participants