Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename class name for ui delegate #553

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Apr 21, 2022

I'm sorry, I added file upload panel in #545 however I used undeclared class name.
In this PR, I fixed the following error.

thread 'main' panicked at 'Class with name UIFileUploadPanelController could not be found', src/webview/wkwebview/mod.rs:396:17

You can reproduce with the following steps.

  1. run cargo run --example multi_window
  2. click button
  3. panicked

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@keiya01 keiya01 requested a review from a team April 21, 2022 12:46
@wusyong wusyong merged commit 76f18e0 into tauri-apps:dev Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants