Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of JS for syncable but not-yet-synced orders #344

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

sethobey
Copy link
Contributor

Context

Identified bug in phtml logic where a Sales Order that has yet to be synced or fails to sync, but has reached a syncable status will not render the necessary JS to manual sync order to TaxJar

Description

Moves PHP endif before JS script tag open so JS will render whether order has been synced or not.

Performance

Break/fix

Testing

  1. Create sales order with TJ module disabled
  2. Enable TJ module
  3. Navigate to sales order
  4. Click "Sync to TaxJar" button in actions panel, order is synced

Versions

  • Magento 2.4
  • Magento 2.3
  • Magento Open Source (formerly Magento 2 Community Edition)
  • Adobe Commerce (formerly Magento 2 Enterprise Edition)
  • PHP 8.2
  • PHP 8.1
  • PHP 7.4
  • PHP 7.3

@sethobey sethobey merged commit dfd907f into develop Sep 27, 2022
@sethobey sethobey deleted the fix-sales-order-manual-sync-button-js branch September 27, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants